Contribute OTLP UDP Exporter #1035
Conversation
...rter/src/main/java/software/opentelemetry/exporters/otlp/udp/OtlpUdpSpanExporterBuilder.java
Outdated
Show resolved
Hide resolved
…dy working in Lambda environment or not
…version in the build file
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1035 +/- ##
=============================================
- Coverage 85.71% 69.49% -16.22%
- Complexity 19 325 +306
=============================================
Files 3 26 +23
Lines 49 1177 +1128
Branches 5 166 +161
=============================================
+ Hits 42 818 +776
- Misses 3 304 +301
- Partials 4 55 +51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Jeel-mehta
force-pushed
the
contribute-udp-exporter
branch
from
cc6f38c to
6fb094a
Compare
|
Apart from the open comments, the rest of the PR lgtm! |
…g a separate settings.gradle file for our exporter
.../java/software/amazon/opentelemetry/exporters/otlp/udp/trace/OtlpUdpSpanExporterBuilder.java
Outdated
Show resolved
Hide resolved
.../java/software/amazon/opentelemetry/exporters/otlp/udp/trace/OtlpUdpSpanExporterBuilder.java
Outdated
Show resolved
Hide resolved
.../java/software/amazon/opentelemetry/exporters/otlp/udp/trace/OtlpUdpSpanExporterBuilder.java
Show resolved
Hide resolved
…ivate cmethod and reuse it again wherever needed
Jeel-mehta
force-pushed
the
contribute-udp-exporter
branch
from
43f06f8 to
41e00ff
Compare
Jeel-mehta
force-pushed
the
contribute-udp-exporter
branch
from
41e00ff to
47b8655
Compare
Jeel-mehta
force-pushed
the
contribute-udp-exporter
branch
from
be01061 to
d997980
Compare
jj22ee
left a comment
jj22ee
left a comment
There was a problem hiding this comment.
fyi, I don't see the unit tests automatically running in the workflows anymore.
Given you have already run the unit tests successfully locally, and the future release workflow will run the unit tests, let's get this merged as to not delay this PR further. I'll followup with a workflow that runs the unit tests when the steps to publish this exporter are added.
5 participants
Issue #, if available:
Description of changes:
Contributing our OTLP UDP exporter.
Testing:
Published the package to MavenLocal and tried running the sample app
Ran the unit tests as well
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.